Repository navigation
Conversation
CI does not run the regression tests in src/pl/plpython, so nobody sees when PL/Python breaks. Add an ic-plpython test job that runs them on Rocky 8, 9 and 10. Assisted-by: Claude Code
PostgreSQL 16 does not have the plpythonu language any more, but the Cloudberry tests plpython_gpdb, plpython_test and plpython_subtransaction still use it. So their functions are not created. In plpython_subtransaction this is worse: test_func() does not exist, so the injected fault never triggers, and gp_wait_until_triggered_fault() waits until the test times out. Use plpython3u, as the upstream tests do. Assisted-by: Claude Code
The REL_16_9 merge took the upstream REGRESS_OPTS and lost --init-file=$(srcdir)/init_file. This file hides the NOTICE and HINT about the distribution key, and the "(plpy_elog.c:N)" position that Cloudberry adds to PL/Python errors. Without it, 9 more tests fail on these lines only. Use the init file again. Assisted-by: Claude Code
The REL_16_9 merge took the upstream expected output of three tests and lost the Cloudberry differences: - plpython_trigger: Cloudberry does not allow an UPDATE of the distribution key of a table with an update trigger. - plpython_error_5: Cloudberry puts the function name in "error fetching next item from iterator". - plpython_transaction: Cloudberry does not enforce foreign keys, so the test injects a fault to fail the COMMIT. The error and its SQLSTATE come from the fault. Restore the output that the tests had before the merge. Now all 24 tests pass on Rocky 8, 9 and 10. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI does not run the regression tests in src/pl/plpython, so nobody sees when PL/Python breaks.
Add an ic-plpython test job that runs them on Rocky 8, 9 and 10.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions