Repository navigation
Conversation
CI does not run the TAP tests in src/bin/pg_rewind, so nobody sees when pg_rewind breaks. gprecoverseg uses pg_rewind for incremental recovery. Add an ic-pg-rewind test job that runs them on Rocky 8, 9 and 10. Assisted-by: Claude Code
Member
Author
|
Note: This separate PR addresses the failing test and is easy to review; once fixed, I’ll consolidate the similar tests into one. |
The REL_16_9 merge removed the declaration of %params from run_pg_rewind(), but kept the code that uses it. So RewindTest.pm does not compile, and each test that uses it stops at once: Global symbol "%params" requires explicit package name Declare %params again. Since PostgreSQL 15, run_pg_rewind() also copies postgresql.conf to a temporary directory and gives the copy to pg_rewind --config-file. In Cloudberry, postgresql.conf includes internal.auto.conf, which sets gp_dbid, by a relative path. So copy internal.auto.conf next to it. Assisted-by: Claude Code
The Cloudberry tests 101 to 106 use the TestLib module, which PostgreSQL 16 does not have any more. Use PostgreSQL::Test::Utils instead. They also have a fixed test plan, and the shared code in RewindTest.pm now makes more checks. For example, 101_ao_rewind.pl plans 17 tests but runs 41. Use done_testing(), as the upstream pg_rewind tests do. Assisted-by: Claude Code
wait_for_catchup() finds the standby in pg_stat_replication by its application name: the name of the node, or "walreceiver". But in Cloudberry, the recovery configuration that pg_basebackup -R and pg_rewind --write-recovery-conf write sets the application name to "gp_walreceiver". So a test that waits for such a standby times out, for example 007_standby_source.pl: timed out waiting for catchup at t/007_standby_source.pl line 162. Also accept "gp_walreceiver". Assisted-by: Claude Code
leborchuk
approved these changes
Nov 6, 2026
leborchuk
left a comment
leborchuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just fixes tests here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI does not run the TAP tests in
src/bin/pg_rewind, so nobody sees whenpg_rewindbreaks. gprecoverseg usespg_rewindfor incremental recovery.Add an ic-pg-rewind test job that runs them on Rocky 8, 9 and 10.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions