Repository navigation
Conversation
The test steps join make_configs with spaces and then split the result on spaces. An entry that contains a space, such as "dir:all installcheck", becomes two configurations, and the second one has no directory. Join the entries with newlines and read one entry per line instead. All current entries give the same configurations as before. apache#2237 has the same change. Assisted-by: Claude Code
CI does not run the tests in src/test/modules/test_pg_dump, so nobody sees when pg_dump breaks for objects that belong to an extension. Add an ic-test-pg-dump test job that runs its regression test and its TAP test on Rocky 8, 9 and 10. The build does not install the module, so the job runs "install installcheck". Assisted-by: Claude Code
The regression test expects no 'e' entries in pg_init_privs after it drops its extension. But each Cloudberry database has the gp_toolkit extension, and its objects have such entries too. Look only for the entries of objects that do not exist any more, which is what the test is about. The TAP test then runs, and 20 of its 964 checks fail on behavior that is different in Cloudberry: - The default cache of a sequence is 20, not 1. - So nextval() takes 20 values, and pg_dump writes setval(..., 20). - pg_dump writes the SQL data access of a function, CONTAINS SQL. Expect these. Now both tests pass on Rocky 8, 9 and 10. Assisted-by: Claude Code
Member
Author
|
Note: This separate PR addresses the failing test and is easy to review; once fixed, I’ll consolidate the similar tests into one. |
The comments that the earlier commits of this change added name the project as "GPDB". Use "Cloudberry" instead. Only comments change. Assisted-by: Claude Code
Member
Author
|
Need to rebase on #2243 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions