Repository navigation
Conversation
CI does not run the regression tests in src/pl/plpgsql/src, so nobody sees when they break. Add an ic-plpgsql test job that runs them on Rocky 8, 9 and 10. Assisted-by: Claude Code
PostgreSQL 16 does not allow RESET of the transaction isolation level (commit 3853664), so the test now sets SERIALIZABLE as the third level instead. The REL_16_9 merge took the new test and its expected output. Cloudberry does not support serializable and uses repeatable read instead (see check_transaction_isolation()), so the test reports: -INFO: serializable +INFO: repeatable read Expect "repeatable read". The test still shows that SET TRANSACTION after COMMIT has an effect, because the new transaction otherwise uses read committed. Now the suite passes 13 of 13 on Rocky 8, 9 and 10, instead of 12. Assisted-by: Claude Code
Member
Author
Let us add commits to fix the failed test. |
Member
|
We need to gather those small tests into one pipeline. |
Member
Author
Will do. These separate PRs target the failing tests; once all are fixed, I’ll consolidate them into one. |
Member
Author
|
Note: This separate PR addresses the failing test and is easy to review; once fixed, I’ll consolidate the similar tests into one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI does not run the regression tests in src/pl/plpgsql/src, so nobody sees when they break.
Add an ic-plpgsql test job that runs them on Rocky 8, 9 and 10.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions