Skip to content

cdbpath_motion_for_parallel_join() refactor #27

Closed

Description

@avamingli

Cloudberry Database version

No response

What happened

cdbpath_motion_for_parallel_join() has most duplicated codes with cdbpath_motion_for_join(),
we separate them for clean codes.

Some codes are not used for parallel, for example, handle update in parallel mode is meaningless.
We have a refactor for SegmentGeneralWorkers as outer side, but lack for other locus.

By reviewing the codes, some potential bugs are found.
As this part of codes is critical, should fix them after refactor to avoid a big change.

What you think should happen instead

No response

How to reproduce

@tuhaihe This is exactly an enhancement, but I can't find a enhancement label or remove Bug label for it.

Some fields in this template are not suite for enhancement. And I can't set assignees either.

Operating System

no need

Anything else

No response

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Activity

  1. added and removed
    type: BugSomething isn't working
    on Jul 21, 2023
  2. tuhaihe commented on Jul 21, 2023

    @tuhaihe
    Member

    Hi @avamingli , I have helped updated your issue's label to type: Enhancement. The newly created issues are default labeled with type: Bug, only the people who have the triage privilege can update them.

    /cc @my-ship-it Hi, Max, we need to redesign the org member roles for future collaborations.

  3. avamingli commented on Jul 21, 2023

    @avamingli
    ContributorAuthor

    Hi @avamingli , I have helped updated your issue's label to type: Enhancement. The newly created issues are default labeled with type: Bug, only the people who have the triage privilege can update them.

    /cc @my-ship-it Hi, Max, we need to redesign the org member roles for future collaborations.

    Thanks for help:)

  4. added
    type: RefactoringA code change that neither fixes a bug nor adds a feature
    and removed on Jul 24, 2023
  5. self-assigned this
    on Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: RefactoringA code change that neither fixes a bug nor adds a feature

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions