Repository navigation
Fix op type - #137
Open
gfphoenix78 wants to merge 1 commit into
Open
Fix op type#137gfphoenix78 wants to merge 1 commit into
gfphoenix78 wants to merge 1 commit into
Conversation
Both spellings remove the ambiguity, for the same reason: the tie was between text || anynonarray, which reads the literal as text, and anycompatiblearray || anycompatible, which reads it as an array, and giving either side a type kills the array reading. But they do not land on the same operator. 'pg_manifest_'::text || paxtables.oid text || anynonarray 'pg_manifest_' || paxtables.oid::text text || text Casting the literal leaves one candidate only because the alternatives need casts that do not exist -- there is no implicit oid-to-text, nor integer-to-text for the fixtures -- so resolution succeeds by elimination, and the surviving operator renders the right side through its type output function. Casting the value instead makes both sides text, and that wins on the earlier rule: it is the candidate with the most exact input matches, settled before the type-category rules the ambiguity turned on in the first place. Prefer that. The operand whose type was ever in question is the value, not the literal, so the cast reads as what it is -- this oid is being rendered as part of a relation name -- and it keeps saying the right thing if that column's type ever changes. The manifest layout's path column is text today and the catalog layout's columns are already cast explicitly, but neither is this file's to guarantee. Restore the indentation of the continuation lines in the two IN lists while here.
gfphoenix78
force-pushed
the
fix-op-type
branch
from
November 7, 2026 07:49
830a009 to
130f9ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: