Repository navigation
Conversation
Member
|
Thanks @cbaecker, the fast path idea is good and the numbers made the case. I've pushed a reworked version directly to master in 2e99457, so I'm closing this PR in favor of it:
I checked it against the old regex-only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on:
Adds a fastpath for
KeyMatch2()/KeyMatch3(), checking if regex-evaluation is actually required.My test with 1000 random (failing) requests resulted in a ~6 times faster performance.
Real-world scenario on embedded was about 2 times faster for initial (non-cached) request.