Repository navigation
GH-55163: [CI] Replace the PR Limit workflow with the .asf.yaml pull request creation cap - #55164
Conversation
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The supported configuration, workflow removal, and documentation consistently implement the intended policy change, with no unresolved findings.
No open issues 🎉
What changed in this PR
Replaces Arrow’s PR-limit workflow with GitHub’s native creation cap configured through .asf.yaml, as proposed in #55163.
Changes:
- Caps contributors without write access at three open pull requests, including drafts.
- Removes the workflow, enforcement script, and automatic closure message.
- Updates contributor documentation to explain creation-time blocking and the removal of the triage-access exemption.
| File | Description |
|---|---|
docs/source/developers/bug_reports.rst |
Documents the native cap and updated access exemption. |
.github/workflows/pr_limit/comment.md |
Removes the obsolete closure message. |
.github/workflows/pr_limit/check.js |
Removes custom PR-limit enforcement. |
.github/workflows/pr_limit.yml |
Removes the replaced GitHub Actions workflow. |
.asf.yaml |
Enables the three-PR creation cap, including drafts. |
Review effort: Balanced
raulcd
left a comment
There was a problem hiding this comment.
That makes sense but my only concern is that now collaborators won't be able to have more than 3 PRs opened until the bypass users PR is merged:
… pull request creation cap GitHub's native pull request creation cap can now be configured in .asf.yaml (apache/infrastructure-asfyaml#111), so configure it there with the same limit and remove the workflow and its helper script. Draft pull requests are included to match the workflow's behaviour. Update the contributor docs: GitHub refuses to open a pull request over the limit instead of closing it afterwards with a comment, and the cap only exempts users with write access.
f16b2d7 to
96bc5df
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Now what apache/infrastructure-asfyaml#135 was merged we can use ASF PR cap mechanism and use GitHub did add a way to introduce a cap and bypass it if a user has an arbitrary numbers of PRs merged (#55163 (comment)). However this is not yet available through |
|
@rok One question: should draft PRs also count towards the creation cap? Since drafts are still work in progress and aren't necessarily ready for review, it might be worth considering whether they should be excluded from the limit. I wonder if counting them might be a bit restrictive for legitimate contributors |
The goal of this is to reduce spam PRs so reading https://github.com/apache/arrow/pulls becomes realistically doable again. I'm unsure but I'd slightly rather first count drafts towards a cap and add legitimate users to |
Reranko05
left a comment
There was a problem hiding this comment.
first count drafts towards a cap and add legitimate users to bypass_users as we go
Makes sense. LGTM!

Rationale for this change
NOTE: do not merge before apache/infrastructure-asfyaml#135 is merged.
See #55163 and #51200.
What changes are included in this PR?
Removes
.github/workflows/pr_limit.ymlworflow and uses a.asf.yamlsetting instead.Committers, collaborators and
pull_requests.creation_cap.bypass_userslist in.asf.yamlare exempt from the cap.Are these changes tested?
Hopefully by CI.
Are there any user-facing changes?
Only CI users.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: