Repository navigation
MINOR: [R][Dev] Fix silent CMake failure in nixlibs.R with CMake>4 - #49865
Merged
Merged
Conversation
without cmake_minimum_required, probing for s3 was failing for me
36 of 37 tasks
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 793fb89. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 793fb89. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…pache#49865) ### Rationale for this change On my Mac, when I try to install the R package from main, I get a confusing warning that S3 support is disabled: ``` **** cmake 4.3.0: /opt/homebrew/bin/cmake **** S3 support requires libcurl-devel (rpm) or libcurl4-openssl-dev (deb) ; building with ARROW_S3=OFF ``` I figured out we were getting a failure from the cmake invocation, ``` CMake Error in CMakeLists.txt: No cmake_minimum_required command is present. A line of code such as cmake_minimum_required(VERSION 4.3) should be added at the top of the file. The version specified may be lower if you wish to support older CMake versions for this project. For more information run "cmake --help-policy CMP0000". ``` but silently ignoring it because the subprocess call hardcoded ignoring stdout/stderr. ### What changes are included in this PR? - Fixes the issue with cmake by specifying `cmake_minimum_required` - Makes the cmake command respect `quietly` (ARROW_R_DEV) so we don't swallow errors ### Are these changes tested? Yes. ### Are there any user-facing changes? No. Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Bryce Mecum <petridish@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
On my Mac, when I try to install the R package from main, I get a confusing warning that S3 support is disabled:
I figured out we were getting a failure from the cmake invocation,
but silently ignoring it because the subprocess call hardcoded ignoring stdout/stderr.
What changes are included in this PR?
cmake_minimum_requiredquietly(ARROW_R_DEV) so we don't swallow errorsAre these changes tested?
Yes.
Are there any user-facing changes?
No.