Skip to content

GH-47753: [C++][Parquet] Build Thrift with OpenSSL disabled - #47754

Merged
kou merged 1 commit into
apache:mainfrom
pitrou:gh47753-thrift-ssl
Oct 9, 2025
Merged

kou merged 1 commit into
apache:mainfrom
pitrou:gh47753-thrift-ssl

Conversation

@pitrou

@pitrou pitrou commented Oct 8, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

The Thrift build chain enables OpenSSL support by default, but we don't need it.

Are these changes tested?

Yes, by existing CI builds.

Are there any user-facing changes?

No.

@pitrou

pitrou commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g cpp

@pitrou
pitrou requested a review from kou October 8, 2025 13:39
@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown

Revision: 1ff996a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1373ebaa70

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou pitrou added the CI: Extra: C++ Run extra C++ CI label Oct 8, 2025

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou
kou merged commit d271e50 into apache:main Oct 9, 2025
@pitrou
pitrou deleted the gh47753-thrift-ssl branch October 9, 2025 06:09
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d271e50.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Oct 15, 2025
…ache#47754)

### Rationale for this change

The Thrift build chain enables OpenSSL support by default, but we don't need it.

### Are these changes tested?

Yes, by existing CI builds.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#47753

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…ache#47754)

### Rationale for this change

The Thrift build chain enables OpenSSL support by default, but we don't need it.

### Are these changes tested?

Yes, by existing CI builds.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#47753

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants