Skip to content

GH-47485: [C++][CI] Work around Valgrind failure on Azure tests - #47496

Merged
pitrou merged 1 commit into
apache:mainfrom
pitrou:gh47485-azure-valgrind
Sep 4, 2025
Merged

pitrou merged 1 commit into
apache:mainfrom
pitrou:gh47485-azure-valgrind

Conversation

@pitrou

@pitrou pitrou commented Sep 4, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

The Azure tests fail because of a likely bug in the Azure SDK, which tries to deallocate a curl shared handler while it's still in use, and doesn't report deallocation errors (reported upstream at Azure/azure-sdk-for-cpp#6722).

What changes are included in this PR?

Add a dedicated Valgrind suppression to ignore the corresponding memory leak.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

The Azure tests fail because of a likely bug in the Azure SDK, which tries to deallocate a curl shared handler while it's still in use, and doesn't report deallocation errors (reported upstream at Azure/azure-sdk-for-cpp#6722).

This PR adds a dedicated Valgrind suppression to ignore the corresponding memory leak.
@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47485 has been automatically assigned in GitHub to PR creator.

@pitrou

pitrou commented Sep 4, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g cpp

@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown

Revision: 677ebac

Submitted crossbow builds: ursacomputing/crossbow @ actions-275be2b2fa

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou
pitrou merged commit 512dcd7 into apache:main Sep 4, 2025
@pitrou
pitrou deleted the gh47485-azure-valgrind branch September 4, 2025 09:56
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 512dcd7.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Oct 15, 2025
…apache#47496)

### Rationale for this change

The Azure tests fail because of a likely bug in the Azure SDK, which tries to deallocate a curl shared handler while it's still in use, and doesn't report deallocation errors (reported upstream at Azure/azure-sdk-for-cpp#6722).

### What changes are included in this PR?

Add a dedicated Valgrind suppression to ignore the corresponding memory leak.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#47485

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…apache#47496)

### Rationale for this change

The Azure tests fail because of a likely bug in the Azure SDK, which tries to deallocate a curl shared handler while it's still in use, and doesn't report deallocation errors (reported upstream at Azure/azure-sdk-for-cpp#6722).

### What changes are included in this PR?

Add a dedicated Valgrind suppression to ignore the corresponding memory leak.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#47485

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants