Repository navigation
GH-46130: [Python] Remove use_legacy_format in favour of setting IpcWriteOptions - #46131
Conversation
|
|
||
|
|
||
| def new_stream(sink, schema, *, use_legacy_format=None, options=None): | ||
| def new_stream(sink, schema, *, options=None): |
There was a problem hiding this comment.
There hasn’t been a clean way to deprecate these so far. One approach could be to leave this PR open for now and introduce deprecation warnings in a separate PR first.
There was a problem hiding this comment.
This has been the name of the field for more than 5 years (use_legacy_format and the documentation said it was deprecated). Maybe we do not require to wait for a DeprecationWarning for a field that has been documented as deprecated for 5 years and has the name legacy on it? This is the commit that introduced the field (Arrow 1.0 already had it as legacy)
1a7519f
and it seems we can still use an environment variable to force using it :)
There was a problem hiding this comment.
I'm a bit on the fence here, but I noticed that David has approved, and it looks like you, @raulcd, are on board as well. Unless there are any objections, I'll go ahead and merge this later today.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 586ed92. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
use_legacy_formatin the ipc writer has been deprecated and can be removed.What changes are included in this PR?
use_legacy_formatkeyword is removed in favour of settingIpcWriteOptions.Are these changes tested?
Existing tests should pass.
Are there any user-facing changes?
Deprecated functionality is removed.
use_legacy_formatin favour of settingIpcWriteOptions#46130