Repository navigation
GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall - #45932
Merged
AlenkaF merged 4 commits intoMar 28, 2025
Merged
Conversation
AlenkaF
commented
Mar 25, 2025
lidavidm
approved these changes
Mar 25, 2025
Member
Author
|
@github-actions crossbow submit -g cpp -g python |
|
Revision: c6d4f821ed0f58584cfa41e9234d134306a8d4a0 Submitted crossbow builds: ursacomputing/crossbow @ actions-d78175be76 |
AlenkaF
force-pushed
the
gh-45922-remove-flight-deprecations
branch
from
March 28, 2025 08:36
c6d4f82 to
f1d71f4
Compare
Member
Author
|
@github-actions crossbow submit test-debian-12-python-3-i386 |
|
Revision: f1d71f4 Submitted crossbow builds: ursacomputing/crossbow @ actions-f95b9094b7
|
Member
Author
|
Emscripten and AppVeyor failures are not related. Plan to merge later today. |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 618ef50. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
…tCall (apache#45932) ### Rationale for this change [Authenticate](https://github.com/apache/arrow/blob/c124bb55d993daca93742ce896869ab3101dccbb/cpp/src/arrow/flight/server_auth.h#L76) and [StartCall](https://github.com/apache/arrow/blob/c124bb55d993daca93742ce896869ab3101dccbb/cpp/src/arrow/flight/server_middleware.h#L94) have been deprecated in 13.0.0 and can now be removed. ### What changes are included in this PR? `ServerAuthHandler.Authenticate` and `ServerMiddlewareFactory.StartCall` versions without `ServerCallContext` are removed. ### Are these changes tested? Existing tests should pass. ### Are there any user-facing changes? Deprecated Flight functionality is removed. * GitHub Issue: apache#45922 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Authenticate and StartCall have been deprecated in 13.0.0 and can now be removed.
What changes are included in this PR?
ServerAuthHandler.AuthenticateandServerMiddlewareFactory.StartCallversions withoutServerCallContextare removed.Are these changes tested?
Existing tests should pass.
Are there any user-facing changes?
Deprecated Flight functionality is removed.