Skip to content

GH-45922: [C++][Flight] Remove deprecated Authenticate and StartCall - #45932

Merged
AlenkaF merged 4 commits into
apache:mainfrom
AlenkaF:gh-45922-remove-flight-deprecations
Mar 28, 2025
Merged

AlenkaF merged 4 commits into
apache:mainfrom
AlenkaF:gh-45922-remove-flight-deprecations

Conversation

@AlenkaF

@AlenkaF AlenkaF commented Mar 25, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

Authenticate and StartCall have been deprecated in 13.0.0 and can now be removed.

What changes are included in this PR?

ServerAuthHandler.Authenticate and ServerMiddlewareFactory.StartCall versions without ServerCallContext are removed.

Are these changes tested?

Existing tests should pass.

Are there any user-facing changes?

Deprecated Flight functionality is removed.

@AlenkaF
AlenkaF marked this pull request as ready for review March 25, 2025 14:46
@AlenkaF
AlenkaF requested a review from lidavidm as a code owner March 25, 2025 14:46
@AlenkaF

AlenkaF commented Mar 27, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g cpp -g python

@github-actions

Copy link
Copy Markdown

Revision: c6d4f821ed0f58584cfa41e9234d134306a8d4a0

Submitted crossbow builds: ursacomputing/crossbow @ actions-d78175be76

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-meson GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@AlenkaF
AlenkaF force-pushed the gh-45922-remove-flight-deprecations branch from c6d4f82 to f1d71f4 Compare March 28, 2025 08:36
@AlenkaF

AlenkaF commented Mar 28, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-debian-12-python-3-i386

@github-actions

Copy link
Copy Markdown

Revision: f1d71f4

Submitted crossbow builds: ursacomputing/crossbow @ actions-f95b9094b7

Task Status
test-debian-12-python-3-i386 GitHub Actions

@AlenkaF

AlenkaF commented Mar 28, 2025

Copy link
Copy Markdown
Member Author

Emscripten and AppVeyor failures are not related. Plan to merge later today.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 618ef50.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@AlenkaF
AlenkaF deleted the gh-45922-remove-flight-deprecations branch March 28, 2025 13:59
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Apr 15, 2025
…tCall (apache#45932)

### Rationale for this change
[Authenticate](https://github.com/apache/arrow/blob/c124bb55d993daca93742ce896869ab3101dccbb/cpp/src/arrow/flight/server_auth.h#L76) and [StartCall](https://github.com/apache/arrow/blob/c124bb55d993daca93742ce896869ab3101dccbb/cpp/src/arrow/flight/server_middleware.h#L94) have been deprecated in 13.0.0 and can now be removed.

### What changes are included in this PR?
`ServerAuthHandler.Authenticate` and `ServerMiddlewareFactory.StartCall` versions without `ServerCallContext` are removed.

### Are these changes tested?
Existing tests should pass.

### Are there any user-facing changes?
Deprecated Flight functionality is removed.

* GitHub Issue: apache#45922

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants