Skip to content

GH-45848: [C++][Python][R] Remove deprecated PARQUET_2_0 - #45849

Merged
raulcd merged 8 commits into
apache:mainfrom
AlenkaF:remove-deprecated-parquet-2-0
Mar 27, 2025
Merged

raulcd merged 8 commits into
apache:mainfrom
AlenkaF:remove-deprecated-parquet-2-0

Conversation

@AlenkaF

@AlenkaF AlenkaF commented Mar 18, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

PARQUET_2_0 has been deprecated for a while now and can be removed from the codebase.

What changes are included in this PR?

Removal of deprecated enum value PARQUET_2_0, and the corresponding Python and R definitions.

Are these changes tested?

By existing unit tests, some of which have been updated.

Are there any user-facing changes?

@AlenkaF
AlenkaF marked this pull request as ready for review March 25, 2025 09:45
@AlenkaF

AlenkaF commented Mar 25, 2025

Copy link
Copy Markdown
Member Author

The changes in this PR affect C++, Python and R implementations. @wgtmac @raulcd @amoeba @jonkeane could you help with reviewing?

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM (will trigger extra CI). I am wondering whether a couple of removed tests should work with other versions of parquet and if they don't work if that is expected or a bug that we should solve (potentially on a different PR)

Comment thread python/pyarrow/tests/test_pandas.py Resolved
@raulcd

raulcd commented Mar 25, 2025

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g cpp -g python

@github-actions

Copy link
Copy Markdown

Revision: 378e847

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f3be9a296

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-meson GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@AlenkaF

AlenkaF commented Mar 25, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g cpp -g python

@github-actions

Copy link
Copy Markdown

Revision: 52114cd

Submitted crossbow builds: ursacomputing/crossbow @ actions-7f041b810a

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-meson GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone could check the R (and possibly the Parquet C++) changes

@AlenkaF

AlenkaF commented Mar 26, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit example-python-minimal-build-*

@github-actions

Copy link
Copy Markdown

Revision: 52114cd

Submitted crossbow builds: ursacomputing/crossbow @ actions-f4d15da475

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions

@amoeba amoeba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R parts LGTM. I added one commit to sync the docs with the source code.

@AlenkaF

AlenkaF commented Mar 27, 2025

Copy link
Copy Markdown
Member Author

Thank you all for the reviews and additional help!
@pitrou maybe you have time for a check of the C++ changes?

@raulcd

raulcd commented Mar 27, 2025

Copy link
Copy Markdown
Member

Thanks @AlenkaF !

@AlenkaF
AlenkaF deleted the remove-deprecated-parquet-2-0 branch March 27, 2025 11:45
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7c18001.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Apr 15, 2025
…e#45849)

### Rationale for this change
`PARQUET_2_0` has been deprecated for a while now and can be removed from the codebase.

### What changes are included in this PR?
Removal of deprecated enum value `PARQUET_2_0`, and the corresponding Python and R definitions.

### Are these changes tested?
By existing unit tests, some of which have been updated.

### Are there any user-facing changes?
* `PARQUET_2_0` is removed in Parquet C++
* `"2.0"` is not allowed anymore as Parquet version in the PyArrow and R Parquet APIs

* GitHub Issue: apache#45848

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants