Repository navigation
GH-45848: [C++][Python][R] Remove deprecated PARQUET_2_0 - #45849
Conversation
raulcd
left a comment
There was a problem hiding this comment.
The change LGTM (will trigger extra CI). I am wondering whether a couple of removed tests should work with other versions of parquet and if they don't work if that is expected or a bug that we should solve (potentially on a different PR)
|
@github-actions crossbow submit -g cpp -g python |
|
Revision: 378e847 Submitted crossbow builds: ursacomputing/crossbow @ actions-0f3be9a296 |
…e_parquet.Rd" This reverts commit 5e9a456.
|
@github-actions crossbow submit -g cpp -g python |
|
Revision: 52114cd Submitted crossbow builds: ursacomputing/crossbow @ actions-7f041b810a |
raulcd
left a comment
There was a problem hiding this comment.
If someone could check the R (and possibly the Parquet C++) changes
|
@github-actions crossbow submit example-python-minimal-build-* |
|
Revision: 52114cd Submitted crossbow builds: ursacomputing/crossbow @ actions-f4d15da475
|
amoeba
left a comment
There was a problem hiding this comment.
R parts LGTM. I added one commit to sync the docs with the source code.
|
Thank you all for the reviews and additional help! |
|
Thanks @AlenkaF ! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7c18001. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…e#45849) ### Rationale for this change `PARQUET_2_0` has been deprecated for a while now and can be removed from the codebase. ### What changes are included in this PR? Removal of deprecated enum value `PARQUET_2_0`, and the corresponding Python and R definitions. ### Are these changes tested? By existing unit tests, some of which have been updated. ### Are there any user-facing changes? * `PARQUET_2_0` is removed in Parquet C++ * `"2.0"` is not allowed anymore as Parquet version in the PyArrow and R Parquet APIs * GitHub Issue: apache#45848 Lead-authored-by: AlenkaF <frim.alenka@gmail.com> Co-authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
PARQUET_2_0has been deprecated for a while now and can be removed from the codebase.What changes are included in this PR?
Removal of deprecated enum value
PARQUET_2_0, and the corresponding Python and R definitions.Are these changes tested?
By existing unit tests, some of which have been updated.
Are there any user-facing changes?
PARQUET_2_0is removed in Parquet C++"2.0"is not allowed anymore as Parquet version in the PyArrow and R Parquet APIsGitHub Issue: [C++][Python][R] Remove deprecated PARQUET_2_0 #45848