Repository navigation
GH-45744: [C++] Remove deprecated GetNextSegment - #45745
Merged
zanmato1984 merged 3 commits intoMar 12, 2025
Merged
zanmato1984 merged 3 commits into
zanmato1984 merged 3 commits into
Conversation
AlenkaF
marked this pull request as draft
March 11, 2025 13:45
AlenkaF
marked this pull request as ready for review
March 11, 2025 14:30
zanmato1984
approved these changes
Mar 11, 2025
zanmato1984
left a comment
Contributor
There was a problem hiding this comment.
LGTM with only one nit.
zanmato1984
reviewed
Mar 12, 2025
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
Contributor
|
@github-actions crossbow submit -g cpp |
|
Contributor
|
@github-actions crossbow submit -g cpp |
|
Revision: 23f880b Submitted crossbow builds: ursacomputing/crossbow @ actions-23fca30928 |
Contributor
|
CI is good. I'm merging. Thank you @AlenkaF ! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4291dad. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GetNextSegmenthas been deprecated in 18.0.0 and can now be removed.What changes are included in this PR?
GetNextSegmentand related code is removed from compute/row/grouper.cc/.h.Are these changes tested?
The existing tests should pass.
Are there any user-facing changes?
GetNextSegmentis removed in favour ofGetSegment