Skip to content

GH-44790: [Python] Remove use_legacy_dataset from code base - #45742

Merged
AlenkaF merged 2 commits into
apache:mainfrom
AlenkaF:gh-44790-remove-use-legacy-dataset
Mar 12, 2025
Merged

AlenkaF merged 2 commits into
apache:mainfrom
AlenkaF:gh-44790-remove-use-legacy-dataset

Conversation

@AlenkaF

@AlenkaF AlenkaF commented Mar 11, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

Legacy dataset in ParquetDataset has been deprecated since Arrow 15.0.0.
We should remove the warnings and deprecate the use_legacy_dataset keyword arguments.

What changes are included in this PR?

Warnings and use_legacy_dataset keyword argument are removed from ParquetDataset together with connected test test_deprecated_use_legacy_dataset .

Are these changes tested?

Existing tests should pass.

Are there any user-facing changes?

Legacy dataset is removed from ParquetDataset.

@pitrou

pitrou commented Mar 11, 2025

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@github-actions

Copy link
Copy Markdown

Revision: 62398bf

Submitted crossbow builds: ursacomputing/crossbow @ actions-7dd82e2ae6

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last ;)

@AlenkaF
AlenkaF merged commit 9b36c70 into apache:main Mar 12, 2025
@AlenkaF
AlenkaF deleted the gh-44790-remove-use-legacy-dataset branch March 12, 2025 10:08
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9b36c70.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 95 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants