Skip to content

GH-45710: [GLib] Add GArrowStringViewArray - #45711

Merged
kou merged 3 commits into
apache:mainfrom
hiroyuki-sato:topic/string-view-array
Mar 10, 2025
Merged

kou merged 3 commits into
apache:mainfrom
hiroyuki-sato:topic/string-view-array

Conversation

@hiroyuki-sato

@hiroyuki-sato hiroyuki-sato commented Mar 8, 2025 •

Copy link
Copy Markdown
Collaborator

Rationale for this change

arrow::StringViewArray is available in the C++ API.
But, GLib doesn't support that method yet.

What changes are included in this PR?

Add GArrowBinaryViewArray to wrap the arrow::BinaryViewArray class.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@hiroyuki-sato
hiroyuki-sato requested a review from kou as a code owner March 8, 2025 14:06
@github-actions

github-actions Bot commented Mar 8, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #45710 has been automatically assigned in GitHub to PR creator.

Comment thread c_glib/arrow-glib/basic-array.cpp Outdated

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check GARROW_TYPE_BINARY_VIEW_ARRAY is correct just in case.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK.

Comment thread c_glib/arrow-glib/basic-array.cpp Outdated

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check "array" is correct just in case.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK.

Comment thread c_glib/arrow-glib/basic-array.cpp Resolved
Comment thread c_glib/arrow-glib/basic-array.cpp Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK.

Comment thread c_glib/arrow-glib/basic-array.cpp Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK.

@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

CI error doesn't relate to this change. Waiting #45697 merge.

@kou

kou commented Mar 10, 2025

Copy link
Copy Markdown
Member

Could you rebase on main?

@hiroyuki-sato
hiroyuki-sato force-pushed the topic/string-view-array branch from 9b67380 to bb9b231 Compare March 10, 2025 14:05
@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

@kou Thanks! Rebase and CI passed.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 0622f46 into apache:main Mar 10, 2025
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0622f46.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants