Skip to content

GH-45578: [C++] Use max not min in MakeStatisticsArrayMaxApproximate test - #45579

Merged
kou merged 1 commit into
apache:mainfrom
andishgar:record_batch_test_cases
Feb 20, 2025
Merged

kou merged 1 commit into
apache:mainfrom
andishgar:record_batch_test_cases

Conversation

@andishgar

@andishgar andishgar commented Feb 19, 2025 •

Copy link
Copy Markdown
Contributor

Rationale for this change

The test was written for min instead of max.

What changes are included in this PR?

Use max not min for MaxApproximate test case.

Are these changes tested?

Yes, by dedicated unit tests.

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #45578 has been automatically assigned in GitHub to PR creator.

@kou kou changed the title GH-45578:[C++]Fix MakeStatisticsArrayMaxApproximate test case bug GH-45578: [C++] Use max not min in MakeStatisticsArrayMaxApproximate test Feb 19, 2025

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 01e3f1e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

@andishgar
andishgar deleted the record_batch_test_cases branch February 20, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants