Skip to content

GH-45293: [CI] Install patch command to base conda.dockerfile required in case of bundled ORC - #45294

Merged
kou merged 1 commit into
apache:mainfrom
raulcd:GH-45293
Jan 18, 2025
Merged

kou merged 1 commit into
apache:mainfrom
raulcd:GH-45293

Conversation

@raulcd

@raulcd raulcd commented Jan 17, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

Patch command is required for bundled ORC.

What changes are included in this PR?

Adding patch to the based conda image.

Are these changes tested?

Yes via CI

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #45293 has been automatically assigned in GitHub to PR creator.

@raulcd

raulcd commented Jan 17, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: a80ceae

Submitted crossbow builds: ursacomputing/crossbow @ actions-e88155f3e7

Task Status
test-conda-python-emscripten GitHub Actions

@raulcd
raulcd marked this pull request as ready for review January 17, 2025 14:14

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sorry. I missed this case...

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 61c82ea.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants