Repository navigation
GH-44563: [C++] FunctionOptions::{Serialize,Deserialize}() return an error without ARROW_IPC - #45171
Merged
Merged
Conversation
…rn an error without ARROW_IPC It uses IPC format internally. So we can't do them without ARROW_IPC.
github-actions
Bot
added
Component: C++
awaiting committer review
Member
Author
|
We don't need to update our tests because arrow/cpp/cmake_modules/DefineOptions.cmake Lines 219 to 224 in 3752109 |
Member
Author
|
I'll merge this tomorrow for 19.0.0 if nobody objects this. |
mapleFU
approved these changes
Jan 6, 2025
Member
Author
|
Thanks for approval. I'll merge this now. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ada8750. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
They use IPC format internally. So we can't do them without
ARROW_IPC.What changes are included in this PR?
Returns
arrow::Status::NotImplementedwithoutARROW_IPC.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.