Skip to content

GH-45157: [CI][Packaging] Remove explicit pins of gemfury version in dev/tasks/macros.jinja - #45158

Merged
kou merged 3 commits into
apache:mainfrom
amoeba:fix/GH-45157--gemfury-ci-failure
Jan 2, 2025
Merged

kou merged 3 commits into
apache:mainfrom
amoeba:fix/GH-45157--gemfury-ci-failure

Conversation

@amoeba

@amoeba amoeba commented Jan 2, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

This should fix a lot of CI jobs. See #45157.

What changes are included in this PR?

Updated dev/tasks/macros.jinja to remove explicit version pin on the gemfury gem version.

Are these changes tested?

Testing here.

Are there any user-facing changes?

No.

@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #45157 has been automatically assigned in GitHub to PR creator.

@amoeba

amoeba commented Jan 2, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64

@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown

Revision: 22f60b3

Submitted crossbow builds: ursacomputing/crossbow @ actions-511f7c6eb8

Task Status
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions

@amoeba
amoeba force-pushed the fix/GH-45157--gemfury-ci-failure branch from 045cfe8 to 22f60b3 Compare January 2, 2025 18:56
Just testing in this PR, don't merge with this change.
@amoeba

amoeba commented Jan 2, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64

@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown

Revision: b0a329f

Submitted crossbow builds: ursacomputing/crossbow @ actions-5098bb1679

Task Status
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions

This reverts commit b0a329f.
@amoeba
amoeba marked this pull request as ready for review January 2, 2025 19:19
@amoeba

amoeba commented Jan 2, 2025 •

Copy link
Copy Markdown
Member Author

The single crossbow job succeeded with my change, see https://github.com/ursacomputing/crossbow/actions/runs/12587335705/job/35082978768. I only ran the single test because the Gemfury step only runs on main normally. To more fully test the change in this PR, I think it makes sense to just merge this and watch nightlies. Open to other ideas though.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants