Skip to content

GH-45048: [C++][Parquet] Deprecate unused chunk_size parameter in parquet::arrow::FileWriter::NewRowGroup() - #45088

Merged
raulcd merged 7 commits into
apache:mainfrom
kszucs:unused-chunk-size
Jan 15, 2025
Merged

raulcd merged 7 commits into
apache:mainfrom
kszucs:unused-chunk-size

Conversation

@kszucs

@kszucs kszucs commented Dec 20, 2024 •

Copy link
Copy Markdown
Member

Rationale for this change

Just noticed that the implementation doesn't use the parameter.

What changes are included in this PR?

Remove the parameter from NewRowGroup()

Are these changes tested?

Are there any user-facing changes?

The chunk_size parameter is now deprecated.

Comment thread python/pyarrow/_parquet.pxd Resolved

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mapleFU

mapleFU commented Jan 14, 2025

Copy link
Copy Markdown
Member

Can we move forward to merge this?

…e review

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied @kou 's suggestion for the ruby tests. I think we can merge once CI passes.

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot there was a comment still not tackled.

Comment thread python/pyarrow/_parquet.pxd Resolved

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d7dc586.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants