Skip to content

GH-45079: [FlightRPC][C++] Deprecate InitializeFlightUcx before removing UCX - #45080

Merged
kou merged 3 commits into
apache:mainfrom
raulcd:GH-45079
Dec 20, 2024
Merged

kou merged 3 commits into
apache:mainfrom
raulcd:GH-45079

Conversation

@raulcd

@raulcd raulcd commented Dec 19, 2024 •

Copy link
Copy Markdown
Member

Rationale for this change

We want to remove the UCX experiment as discussed on the issue:

Based on the discussions of the PR removal we have decided to deprecate it before.

What changes are included in this PR?

Deprecation of InitializeFlightUcx

Are these changes tested?

No, I don't think we test ARROW_WITH_UCX on CI.

Are there any user-facing changes?

Yes, the PR deprecated Flight UCX

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #45079 has been automatically assigned in GitHub to PR creator.

@raulcd
raulcd marked this pull request as ready for review December 19, 2024 12:34
@raulcd
raulcd requested a review from lidavidm as a code owner December 19, 2024 12:34
@raulcd
raulcd requested a review from kou December 19, 2024 12:34

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


Notes:

* \(1) Flight UCX transport has been deprecated on the 19.0.0 release.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raulcd

raulcd commented Dec 20, 2024

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit preview-docs

@github-actions

Copy link
Copy Markdown

Revision: 3f8e982

Submitted crossbow builds: ursacomputing/crossbow @ actions-a8773b37ea

Task Status
preview-docs GitHub Actions

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 164e18a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants