Repository navigation
GH-43962: [Java] Consider warnings as errors for Adapter Module - #43963
Conversation
|
@lidavidm I am planning to fix the warnings to errors per module at the moment and finally move the flag to the parent pom as we covered the code formatting. Is this approach okay? |
|
@lidavidm this is ready for review. |
There was a problem hiding this comment.
can we possibly simplify this with combine.children="append"?
There was a problem hiding this comment.
Right, let me check.
There was a problem hiding this comment.
I updated, lets check the CIs (locally passing)
github-actions
Bot
added
awaiting changes
f50fac1 to
f083330
Compare
github-actions
Bot
added
awaiting change review
There was a problem hiding this comment.
Append should mean that none of these other arguments are required, right? Only compilerArgs?
There was a problem hiding this comment.
Also should it be combine.self or combine.children?
There was a problem hiding this comment.
Yes, it seems to be the best. I updated, let's wait for the CIs to make sure.
github-actions
Bot
added
awaiting changes
8ce47a4 to
edf6a87
Compare
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2a793d6. There were 4 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…apache#43963) ### Rationale for this change This PR configs the build such that warnings are considered as errors in the Adapter module. And corresponding code changes have also been made. ### What changes are included in this PR? Adding flags to consider warnings as errors in javac and fixing the corresponding errors. ### Are these changes tested? Tested by existing test cases. ### Are there any user-facing changes? N/A * GitHub Issue: apache#43962 Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
…apache#43963) ### Rationale for this change This PR configs the build such that warnings are considered as errors in the Adapter module. And corresponding code changes have also been made. ### What changes are included in this PR? Adding flags to consider warnings as errors in javac and fixing the corresponding errors. ### Are these changes tested? Tested by existing test cases. ### Are there any user-facing changes? N/A * GitHub Issue: apache#43962 Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
This PR configs the build such that warnings are considered as errors in the Adapter module. And corresponding code changes have also been made.
What changes are included in this PR?
Adding flags to consider warnings as errors in javac and fixing the corresponding errors.
Are these changes tested?
Tested by existing test cases.
Are there any user-facing changes?
N/A