Skip to content

GH-43707: [Python] Fix compilation on Cython<3 - #43765

Merged
jorisvandenbossche merged 1 commit into
apache:mainfrom
lidavidm:gh-43707
Aug 20, 2024
Merged

jorisvandenbossche merged 1 commit into
apache:mainfrom
lidavidm:gh-43707

Conversation

@lidavidm

@lidavidm lidavidm commented Aug 20, 2024 •

Copy link
Copy Markdown
Member

Rationale for this change

Fix compilation on Cython < 3

What changes are included in this PR?

Add an explicit cast

Are these changes tested?

N/A

Are there any user-facing changes?

No

@lidavidm

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-conda-python-3.10-cython2

@github-actions

Copy link
Copy Markdown

Revision: 33b739d

Submitted crossbow builds: ursacomputing/crossbow @ actions-73720c071b

Task Status
test-conda-python-3.10-cython2 GitHub Actions

@lidavidm
lidavidm marked this pull request as ready for review August 20, 2024 05:29
@lidavidm
lidavidm requested a review from pitrou August 20, 2024 05:29
@pitrou

pitrou commented Aug 20, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g python

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you!

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b0317f2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants