[mapleFU]

Rationale for this change

See #43382

What changes are included in this PR?

Change stats has min-max from min || max to &&

Are these changes tested?

• TODO

Are there any user-facing changes?

Might affect interface using HasMinMax

This PR includes breaking changes to public APIs.

• GitHub Issue: [C++][Parquet] min-max Statistics doesn't work well when one of min-max being truncated #43382

[github-actions]

⚠️ GitHub issue #43382 has been automatically assigned in GitHub to PR creator.

[mapleFU]

This is just a try, I can also extract has-min and has-max

[mapleFU]

@pitrou @wgtmac would you mind take a look whether this fixing is ok or there is better api? I'll draft testing once api is stable

[wgtmac]

I'm fine to be conservative. So this change looks good. However, the encoded_min and encoded_max are still set. I'd propose to deprecate virtual bool HasMinMax() const = 0; and add virtual bool HasMin() const = 0; and virtual bool HasMax() const = 0;

[mapleFU]

Updated: I'll separate the implemetation into two separate patch:

• The first one is test and remove the || in HasMinMax, changing the syntax to both has-min and has-max
• The second one is add HasMin and HasMax.

Anyway this is a bug rather than feature so we should fix it first

[mapleFU]

@kou @emkornfield @wgtmac would you mind take a look? This patch only change || -> &&

[kou]

+1

Could you uncomment <!-- **This PR includes breaking changes to public APIs.** --> in the PR description?

[wgtmac]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 66cb749.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.