Skip to content

GH-41968: [Java] Implement TransferPair functionality for BinaryView - #41980

Merged
lidavidm merged 2 commits into
apache:mainfrom
vibhatha:gh-41968
Jun 6, 2024
Merged

lidavidm merged 2 commits into
apache:mainfrom
vibhatha:gh-41968

Conversation

@vibhatha

@vibhatha vibhatha commented Jun 5, 2024 •

Copy link
Copy Markdown
Contributor

Rationale for this change

This PR contains the transferPair functionality for BinaryView vectors.

What changes are included in this PR?

This includes the addition of transferPair functionality in ViewVarCharBinaryVector and corresponding test cases.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@vibhatha
vibhatha marked this pull request as ready for review June 5, 2024 11:39
@vibhatha
vibhatha requested a review from lidavidm as a code owner June 5, 2024 11:39
Comment thread java/vector/src/test/java/org/apache/arrow/vector/TestSplitAndTransfer.java Outdated
@github-actions github-actions Bot added awaiting review Awaiting review awaiting merge Awaiting merge awaiting committer review Awaiting committer review and removed awaiting review Awaiting review awaiting merge Awaiting merge labels Jun 6, 2024
@vibhatha

vibhatha commented Jun 6, 2024

Copy link
Copy Markdown
Contributor Author

@lidavidm Updated the PR.

@lidavidm
lidavidm merged commit cea7323 into apache:main Jun 6, 2024
@lidavidm lidavidm removed the awaiting committer review Awaiting committer review label Jun 6, 2024
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jun 6, 2024
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit cea7323.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…yView (apache#41980)

### Rationale for this change

This PR contains the transferPair functionality for BinaryView vectors. 

### What changes are included in this PR?

This includes the addition of transferPair functionality in `ViewVarCharBinaryVector` and corresponding test cases. 

### Are these changes tested?
Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41968

Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants