Skip to content

GH-36399: [Python] Add missing shape property to RecordBatch - #40643

Merged
jorisvandenbossche merged 4 commits into
apache:mainfrom
judahrand:recordbatch/shape
Mar 21, 2024
Merged

jorisvandenbossche merged 4 commits into
apache:mainfrom
judahrand:recordbatch/shape

Conversation

@judahrand

@judahrand judahrand commented Mar 18, 2024 •

Copy link
Copy Markdown
Contributor

Rationale for this change

This property is currently missing.

What changes are included in this PR?

Move the shape property to the _Tabular base class.

Are these changes tested?

Yes. I've merged the test_table_basics and test_record_batch basics tests to make sure that all the same basics are tests on both classes.

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand judahrand changed the title GH-30915: [C++][Python] Add missing shape property to RecordBatch GH-36399: [C++][Python] Add missing shape property to RecordBatch Mar 18, 2024
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #36399 has been automatically assigned in GitHub to PR creator.

@judahrand judahrand changed the title GH-36399: [C++][Python] Add missing shape property to RecordBatch GH-36399: [Python] Add missing shape property to RecordBatch Mar 18, 2024

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just two minor comments

Comment thread python/pyarrow/table.pxi Resolved
Comment thread python/pyarrow/tests/test_table.py Outdated
assert wr() is None


def test_table_str():

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a test_table_repr_to_string that should cover this, I think?

@judahrand judahrand Mar 19, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit cc9d52c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants