Repository navigation
GH-36399: [Python] Add missing shape property to RecordBatch - #40643
Merged
Merged
Conversation
|
|
shape property to RecordBatchshape property to RecordBatch
|
|
shape property to RecordBatchshape property to RecordBatch
jorisvandenbossche
left a comment
Member
There was a problem hiding this comment.
Thanks, just two minor comments
| assert wr() is None | ||
|
|
||
|
|
||
| def test_table_str(): |
Member
There was a problem hiding this comment.
There is already a test_table_repr_to_string that should cover this, I think?
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
judahrand
force-pushed
the
recordbatch/shape
branch
from
March 19, 2024 17:07
1411614 to
b2b3015
Compare
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit cc9d52c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This property is currently missing.
What changes are included in this PR?
Move the
shapeproperty to the_Tabularbase class.Are these changes tested?
Yes. I've merged the
test_table_basicsandtest_record_batchbasics tests to make sure that all the same basics are tests on both classes.Are there any user-facing changes?