Skip to content

GH-30915: [C++][Python] Add missing methods to RecordBatch - #39506

Merged
jorisvandenbossche merged 20 commits into
apache:mainfrom
judahrand:main
Mar 15, 2024
Merged

jorisvandenbossche merged 20 commits into
apache:mainfrom
judahrand:main

Conversation

@judahrand

@judahrand judahrand commented Jan 8, 2024 •

Copy link
Copy Markdown
Contributor

Rationale for this change

These methods are present on Table but missing on RecordBatch:

  • add_column
  • append_column
  • remove_column
  • set_column
  • drop_columns
  • rename_columns
  • cast

We also should probably accept a dict as input to pa.record_batch like we do for pa.table.

What changes are included in this PR?

Add the methods.

Are these changes tested?

Yes.

@github-actions

github-actions Bot commented Jan 8, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@github-actions

github-actions Bot commented Jan 8, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand
judahrand force-pushed the main branch 6 times, most recently from 35235a0 to 423a7ad Compare January 10, 2024 08:54
@judahrand judahrand changed the title GH-30915: [Python] Add add/set/remove_column methods to RecordBatch GH-30915: [Python] Add missing methods to RecordBatch Jan 10, 2024
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand judahrand changed the title GH-30915: [Python] Add missing methods to RecordBatch GH-30915: [C++][Python] Add missing methods to RecordBatch Jan 10, 2024
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

2 similar comments
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@github-actions

github-actions Bot commented Mar 4, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand

Copy link
Copy Markdown
Contributor Author

@benibus @jorisvandenbossche I think that I've dealt with all the feedback on this one.

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last updates, and for the extensive test parametrization of Recordbatch/Table! Looking all good to me now. Will merge once green

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 7f361fd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 25 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] add_column method missing in pyarrow.RecordBatch

3 participants