Repository navigation
GH-37456: [R] CRAN incoming checks show NOTE due to internal function which isn't documented - #37457
Merged
Merged
Conversation
44 tasks done
paleolimbot
approved these changes
Aug 30, 2023
paleolimbot
left a comment
Member
There was a problem hiding this comment.
Thanks!
Just double-checking that this doesn't need a devtools::document() (I forget whether or not these roxygen tags affect that).
paleolimbot
approved these changes
Aug 30, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 58c2c37. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…nction which isn't documented (apache#37457) ### Rationale for this change Failed CRAN check due to updates to their checks on R-devel ### What changes are included in this PR? Add additional roxygen header ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37456 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…nction which isn't documented (apache#37457) ### Rationale for this change Failed CRAN check due to updates to their checks on R-devel ### What changes are included in this PR? Add additional roxygen header ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37456 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Failed CRAN check due to updates to their checks on R-devel
What changes are included in this PR?
Add additional roxygen header
Are these changes tested?
No
Are there any user-facing changes?
No