Skip to content

GH-36820: [C++] Remove a needless return in Acero ScanNode::AddScanTasks #36821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mapleFU wants to merge 1 commit into from
Closed

GH-36820: [C++] Remove a needless return in Acero ScanNode::AddScanTasks #36821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cpp/src/arrow/dataset/scan_node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,6 @@ class ScanNode : public acero::ExecNode, public acero::TracedNode {
scan_tasks->AddTask(std::make_unique<ScanBatchTask>(node, state_view, i));
}
return Status::OK();
// The "list fragments" task doesn't actually end until the fragments are
// all scanned. This allows us to enforce fragment readahead.
return list_and_scan_done;
}

// Take the dataset options, and the fragment evolution, and figure out exactly how
Expand Down