Skip to content

GH-36621: [C++] Add documentation for ACERO_ALIGNMENT_HANDLING - #36622

Merged
kou merged 2 commits into
apache:mainfrom
westonpace:feature/GH-36621--document-acero-alignment-handling
Jul 14, 2023
Merged

kou merged 2 commits into
apache:mainfrom
westonpace:feature/GH-36621--document-acero-alignment-handling

Conversation

@westonpace

@westonpace westonpace commented Jul 11, 2023 •

Copy link
Copy Markdown
Member

Rationale for this change

To document an existing environment variable that was not documented.

What changes are included in this PR?

Adds a documentation section for this environment variable.

Are these changes tested?

No, there are only docs.

Are there any user-facing changes?

New documentation

@westonpace

Copy link
Copy Markdown
Member Author

image

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #36621 has been automatically assigned in GitHub to PR creator.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou pitrou changed the title GH-36621: [C++] Added documentation for ACERO_ALIGNMENT_HANDLING GH-36621: [C++] Add documentation for ACERO_ALIGNMENT_HANDLING Jul 13, 2023

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Some small suggestions for improvement below.

Comment thread docs/source/cpp/env_vars.rst Resolved
Comment thread docs/source/cpp/env_vars.rst Resolved
Comment thread docs/source/cpp/env_vars.rst Resolved
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@kou

kou commented Jul 14, 2023

Copy link
Copy Markdown
Member

@github-actions crossbow submit preview-docs

@github-actions

Copy link
Copy Markdown

Revision: df536f3

Submitted crossbow builds: ursacomputing/crossbow @ actions-ea9fff6db8

Task Status
preview-docs Github Actions

@kou

kou commented Jul 14, 2023

Copy link
Copy Markdown
Member

@kou
kou merged commit 5037ab1 into apache:main Jul 14, 2023
@RichardHaythorn

Copy link
Copy Markdown

@westonpace I see it's already merged but it LGTM

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5037ab1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Document ACERO_ALIGNMENT_HANDLING

4 participants