Skip to content

GH-36482: [C++][CI] Fix sporadic test failures in AsofJoinBasicTest - #36580

Closed
rtpsw wants to merge 1 commit into
apache:mainfrom
rtpsw:GH-36482.invalidate_in_process_thread
Closed

rtpsw wants to merge 1 commit into
apache:mainfrom
rtpsw:GH-36482.invalidate_in_process_thread

Conversation

@rtpsw

@rtpsw rtpsw commented Jul 9, 2023

Copy link
Copy Markdown
Contributor

What changes are included in this PR?

The key hasher is invalidated before the first invocation of GetKey (via GetLatestKey) after a new batch arrives. In the pre-PR code, this invalidation happens within Advance, which is called from AdvanceAndMemoize only after GetLatestKey is called. The change adds numbering to record batches pushed to the processing thread to enable detecting the pushed record batch in order to then invalidate the key hasher.

Are these changes tested?

Yes, by existing tests.

Are there any user-facing changes?

No.

This PR contains a "Critical Fix".

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++][CI] Sporadic test failures in AsofJoinBasicTest

3 participants