Repository navigation
GH-36553: [Python] Improve error message if certain submodule (cython or cpp) is not built - #36554
Merged
Merged
Conversation
…cython or cpp) is not built
|
|
github-actions
Bot
added
Component: Python
Component: FlightRPC
awaiting committer review
Member
Author
|
cc @raulcd I kept the error message quite minimal right now (since we don't know yet how installing optional components with pip or conda would look like) |
Member
|
LGTM! +1 for more helpful error messages. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1a8972b.There were no benchmark performance regressions. 🎉 The full Conbench report has more details.It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Improving the error message when a submodule is not built (by catching the ImportError and re-raising it reworded)