Repository navigation
GH-35710: [R] Followup improvements to new configure script - #36435
Merged
Merged
Conversation
|
|
kou
approved these changes
Jul 3, 2023
kou
left a comment
Member
There was a problem hiding this comment.
+1
Can we use more descriptive PR title?
How about writing commit message contents to the PR description too because our merge script only uses the PR description for merged commit. (Commit messages are discarded.)
Member
Author
|
@kou done, that look better? |
|
Conbench analyzed the 6 benchmark runs on commit There were 12 benchmark results indicating a performance regression:
The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #35710
What changes are included in this PR?
LIB_DIRfrompkg-configwhere possible, to handle the possibility that it islib64and not justlibon some platforms.Are these changes tested?
The version check change has a unit test. The LIB_DIR change hopefully is well enough covered by our existing CI.