Skip to content

GH-35710: [R] Followup improvements to new configure script - #36435

Merged
kou merged 2 commits into
apache:mainfrom
nealrichardson:configure-fixes
Jul 3, 2023
Merged

kou merged 2 commits into
apache:mainfrom
nealrichardson:configure-fixes

Conversation

@nealrichardson

@nealrichardson nealrichardson commented Jul 2, 2023 •

Copy link
Copy Markdown
Member

Rationale for this change

See #35710

What changes are included in this PR?

Are these changes tested?

The version check change has a unit test. The LIB_DIR change hopefully is well enough covered by our existing CI.

@github-actions

github-actions Bot commented Jul 2, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #35710 has been automatically assigned in GitHub to PR creator.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Can we use more descriptive PR title?

How about writing commit message contents to the PR description too because our merge script only uses the PR description for merged commit. (Commit messages are discarded.)

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jul 3, 2023
@nealrichardson nealrichardson changed the title GH-35710: [R] Issues with configure script GH-35710: [R] Followup improvements to new configure script Jul 3, 2023
@nealrichardson

Copy link
Copy Markdown
Member Author

@kou done, that look better?

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks!

@kou
kou merged commit 3f6dfb3 into apache:main Jul 3, 2023
@kou kou removed the awaiting merge Awaiting merge label Jul 3, 2023
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jul 3, 2023
@nealrichardson
nealrichardson deleted the configure-fixes branch July 3, 2023 21:33
@conbench-apache-arrow

Copy link
Copy Markdown

Conbench analyzed the 6 benchmark runs on commit 3f6dfb38.

There were 12 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R] Issues with configure script

2 participants