Skip to content

MINOR: [CI][R] Nightly R upload fails due to wrong branch - #35478

Merged
thisisnic merged 1 commit into
apache:mainfrom
assignUser:fix-nightly-upload
May 10, 2023
Merged

thisisnic merged 1 commit into
apache:mainfrom
assignUser:fix-nightly-upload

Conversation

@assignUser

Copy link
Copy Markdown
Member

The R nightly upload has failed since we renamed the default branch to main in crossbow due to the hardcoded branch name.

@nealrichardson

Copy link
Copy Markdown
Member

Thanks. Why did we not see this was failing? Is there anything we can do to improve our monitoring?

@raulcd

raulcd commented May 8, 2023

Copy link
Copy Markdown
Member

We probably could add a job that validates that the last published nightlies (that could be good for Java, R, Python) are not older than 48 hours. It might be redundant on some cases but might potentially raise these type of issues sooner.

@assignUser

Copy link
Copy Markdown
Member Author

I agree visibility is pretty bad... Usually someone will get an email for failing builds (not sure who is for arrow?) maybe we can get those forwarded to the builds@ mailing list, though that might get spammy fast with all the fails on main we tend to have..

@thisisnic thisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 10, 2023
@thisisnic
thisisnic merged commit ec29c6f into apache:main May 10, 2023
@thisisnic

Copy link
Copy Markdown
Member

@assignUser / @raulcd - how about we use add a step which uses the failure condition to this build? Not sure where's best to send it, but I'd like to work out a way to have the same visibility on this as I do with the nightly tests.

@raulcd

raulcd commented May 10, 2023

Copy link
Copy Markdown
Member

I've created the issue linked above to track this improvement

@ursabot

ursabot commented May 11, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 013de75 and contender = ec29c6f. ec29c6f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️4.27% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.42% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ec29c6ff ec2-t3-xlarge-us-east-2
[Finished] ec29c6ff test-mac-arm
[Finished] ec29c6ff ursa-i9-9960x
[Finished] ec29c6ff ursa-thinkcentre-m75q
[Finished] 013de752 ec2-t3-xlarge-us-east-2
[Finished] 013de752 test-mac-arm
[Finished] 013de752 ursa-i9-9960x
[Finished] 013de752 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented May 11, 2023

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
The [R nightly upload](https://github.com/apache/arrow/actions/runs/4915965925/jobs/8779129556) has failed since we renamed the default branch to main in crossbow due to the hardcoded branch name.

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
The [R nightly upload](https://github.com/apache/arrow/actions/runs/4915965925/jobs/8779129556) has failed since we renamed the default branch to main in crossbow due to the hardcoded branch name.

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants