Skip to content

MINOR: [R] ARROW_ACERO should be ON by default in bundled build - #35407

Merged
nealrichardson merged 1 commit into
apache:mainfrom
nealrichardson:nealrichardson-patch-1
May 5, 2023
Merged

nealrichardson merged 1 commit into
apache:mainfrom
nealrichardson:nealrichardson-patch-1

Conversation

@nealrichardson

Copy link
Copy Markdown
Member

To match ARROW_DATASET. Without this, the default CRAN version on Linux won't have Acero enabled.

This should be cherry-picked for the 12.0.0 CRAN submission. cc @thisisnic

@thisisnic thisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nealrichardson
nealrichardson merged commit c2f7d13 into apache:main May 5, 2023
@nealrichardson
nealrichardson deleted the nealrichardson-patch-1 branch May 5, 2023 14:04
@ursabot

ursabot commented May 5, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 7432cc7 and contender = c2f7d13. c2f7d13 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.15% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c2f7d13e ec2-t3-xlarge-us-east-2
[Failed] c2f7d13e test-mac-arm
[Finished] c2f7d13e ursa-i9-9960x
[Failed] c2f7d13e ursa-thinkcentre-m75q
[Finished] 7432cc7f ec2-t3-xlarge-us-east-2
[Finished] 7432cc7f test-mac-arm
[Finished] 7432cc7f ursa-i9-9960x
[Finished] 7432cc7f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
…he#35407)

To match ARROW_DATASET. Without this, the default CRAN version on Linux
won't have Acero enabled.

This should be cherry-picked for the 12.0.0 CRAN submission.
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
…he#35407)

To match ARROW_DATASET. Without this, the default CRAN version on Linux
won't have Acero enabled.

This should be cherry-picked for the 12.0.0 CRAN submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants