Repository navigation
GH-33616: [C++] Reorder group_by so that keys/segment keys come before aggregates - #34551
Conversation
|
|
|
The failures in the doc build are because the docstring examples in |
|
@nealrichardson R is currently failing, I think, because it is already reordering columns to get the desired behavior. Would you have a chance to take a look and back out that code? If not, I can try and look at it later. |
|
Sure, I can take a look |
|
It seems that we need to update more tests for GLib/Ruby. |
Yes, I would be very grateful. If you want me to fix this though I can. My ruby fixes just tend to be a little "guess and check" with the CI. |
|
Done! |
433f84c to
836e022
Compare
|
@westonpace is there anything blocking this one? It looks also it needs to be rebased. |
836e022 to
700384b
Compare
…ys and segment keys come before aggregates.
700384b to
947060c
Compare
b8f84c2 to
653a051
Compare
|
CI failures are unrelated (and these tests were passing before the acero refactor was rebased). I'm going to go ahead and merge this. |
|
Benchmark runs are scheduled for baseline = 8824aca and contender = 379c1fb. 379c1fb is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
… before aggregates (apache#34551) * Closes: apache#33616 Lead-authored-by: Weston Pace <weston.pace@gmail.com> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.