Skip to content

GH-33616: [C++] Reorder group_by so that keys/segment keys come before aggregates - #34551

Merged
westonpace merged 10 commits into
apache:mainfrom
westonpace:feature/GH-33616--reorder-groupby
Apr 5, 2023
Merged

westonpace merged 10 commits into
apache:mainfrom
westonpace:feature/GH-33616--reorder-groupby

Conversation

@westonpace

@westonpace westonpace commented Mar 13, 2023 •

Copy link
Copy Markdown
Member

@westonpace
westonpace requested a review from AlenkaF as a code owner March 13, 2023 21:31
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #33616 has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche

Copy link
Copy Markdown
Member

The failures in the doc build are because the docstring examples in TableGroupBy.aggregate in table.pxi need to be updated as well (those examples are validated)

@westonpace

Copy link
Copy Markdown
Member Author

@nealrichardson R is currently failing, I think, because it is already reordering columns to get the desired behavior. Would you have a chance to take a look and back out that code? If not, I can try and look at it later.

@nealrichardson

Copy link
Copy Markdown
Member

Sure, I can take a look

@kou

kou commented Mar 15, 2023

Copy link
Copy Markdown
Member

It seems that we need to update more tests for GLib/Ruby.
Can I push changes for it to this branch directly?

@westonpace

westonpace commented Mar 17, 2023 •

Copy link
Copy Markdown
Member Author

It seems that we need to update more tests for GLib/Ruby.
Can I push changes for it to this branch directly?

@kou

Yes, I would be very grateful. If you want me to fix this though I can. My ruby fixes just tend to be a little "guess and check" with the CI.

@kou

kou commented Mar 17, 2023

Copy link
Copy Markdown
Member

Done!

@westonpace
westonpace force-pushed the feature/GH-33616--reorder-groupby branch from 433f84c to 836e022 Compare March 22, 2023 14:04
@amol-

amol- commented Apr 3, 2023

Copy link
Copy Markdown
Member

@westonpace is there anything blocking this one? It looks also it needs to be rebased.

@westonpace
westonpace force-pushed the feature/GH-33616--reorder-groupby branch from 700384b to 947060c Compare April 4, 2023 06:53
@westonpace
westonpace force-pushed the feature/GH-33616--reorder-groupby branch from b8f84c2 to 653a051 Compare April 4, 2023 07:30
@westonpace

Copy link
Copy Markdown
Member Author

CI failures are unrelated (and these tests were passing before the acero refactor was rebased). I'm going to go ahead and merge this.

@westonpace
westonpace merged commit 379c1fb into apache:main Apr 5, 2023
@ursabot

ursabot commented Apr 5, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8824aca and contender = 379c1fb. 379c1fb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️1.11%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 379c1fb0 ec2-t3-xlarge-us-east-2
[Failed] 379c1fb0 test-mac-arm
[Finished] 379c1fb0 ursa-i9-9960x
[Failed] 379c1fb0 ursa-thinkcentre-m75q
[Finished] 8824acac ec2-t3-xlarge-us-east-2
[Failed] 8824acac test-mac-arm
[Finished] 8824acac ursa-i9-9960x
[Failed] 8824acac ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
… before aggregates (apache#34551)

* Closes: apache#33616

Lead-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Group_By from Substrait Shuffles Column Names

6 participants