Repository navigation
MINOR: [C++] Fix compilation error in hash_join_benchmark - #34000
Conversation
|
The expected return type was changed from |
kou
left a comment
There was a problem hiding this comment.
+1
We need additional -DARROW_BUILD_OPENMP_BENCHMARKS=ON option to build this benchmark. Our CI jobs don't cover it.
|
Benchmark runs are scheduled for baseline = b0e1037 and contender = 899146b. 899146b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
HashJoinImpl::Initexpectsoutput_batch_callbackandfinished_callbackto returnStatus, while the currently passed arguments return void. It caused compilation errors on my machine.What changes are included in this PR?
Fix the return types.
Are these changes tested?
Yes. It fixes the compilation error on my machine.
Are there any user-facing changes?
No.