Skip to content

GH-14976: [Python] Avoid dependency on exec plan in Table.sort_by to fix minimal tests - #15268

Merged
kou merged 1 commit into
apache:masterfrom
jorisvandenbossche:minor-sort-not-require-dataset
Jan 9, 2023
Merged

kou merged 1 commit into
apache:masterfrom
jorisvandenbossche:minor-sort-not-require-dataset

Conversation

@jorisvandenbossche

@jorisvandenbossche jorisvandenbossche commented Jan 9, 2023 •

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Jan 9, 2023

Copy link
Copy Markdown

@jorisvandenbossche

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit example-python-minimal-build-fedora-conda example-python-minimal-build-ubuntu-venv

@github-actions

github-actions Bot commented Jan 9, 2023

Copy link
Copy Markdown

Revision: f174868

Submitted crossbow builds: ursacomputing/crossbow @ actions-ac333dad73

Task Status
example-python-minimal-build-fedora-conda Github Actions
example-python-minimal-build-ubuntu-venv Github Actions

@jorisvandenbossche

Copy link
Copy Markdown
Member Author

The alternative is to simply mark those tests with @pytest.mark.dataset as a proxy to indicate that exec plan is not available.

But since this method worked previously with a minimal python install, we can easily keep it working.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@kou
kou merged commit 154de48 into apache:master Jan 9, 2023
@jorisvandenbossche
jorisvandenbossche deleted the minor-sort-not-require-dataset branch January 9, 2023 13:51
@ursabot

ursabot commented Jan 10, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5f3df12 and contender = 154de48. 154de48 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.58% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.1% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 154de48f ec2-t3-xlarge-us-east-2
[Finished] 154de48f test-mac-arm
[Finished] 154de48f ursa-i9-9960x
[Finished] 154de48f ursa-thinkcentre-m75q
[Finished] 5f3df125 ec2-t3-xlarge-us-east-2
[Finished] 5f3df125 test-mac-arm
[Finished] 5f3df125 ursa-i9-9960x
[Finished] 5f3df125 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 10, 2023
…by to fix minimal tests (apache#15268)

* Closes: apache#14976

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants