Repository navigation
GH-15216: [C++][Parquet] Parquet writer accepts RecordBatch - #15240
Conversation
|
|
|
|
|
@emkornfield @pitrou @wjones127 Could you please take a look? Thanks! |
wjones127
left a comment
There was a problem hiding this comment.
This looks very useful! I have noted a few places where we could use a bit more tests and documentation to clarify some behavior.
wjones127
left a comment
There was a problem hiding this comment.
Looking very good. I suggest one small change to a test so we use that leaf_count() call within the loop properly.
All comments have been addressed. Please take a look again. Thanks! |
|
Looks good. @wgtmac could you rebase? Have conflicts since I merged the other PR. Once that's complete, this should be good to merge. |
- Parquet arrow::FileWriter supports buffered row group mode. - Parquet arrow::FileWriter accepts arrow::RecordBatch.
@wjones127 Thanks for your review! I have rebased and updated the PR. Please check again. |
|
Benchmark runs are scheduled for baseline = 3146588 and contender = 427a865. 427a865 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Uh oh!
There was an error while loading. Please reload this page.