Repository navigation
GH-33580: [C++] Support emit info in Substrait extension-multi and AsOfJoin - #14799
Conversation
|
@westonpace, as compared to westonpace#27, this PR is against master. Note that the current commit includes some unrelated changes to |
|
Note about this recent commit: In gdb, the error had this backtrace: I observed that gdb is able to statically cast to This suggests something with the RTTI of |
|
I looked into the ASAN failure, and I suspect that it is because |
|
The recent commit fixed the ASAN failure by avoiding a null executor, so that the Note that accepting this commit would cause any code out there that uses as-of-join with a null executor (as in the current default exec context) to fail. My understanding is that the API is experimental right now, so it should be OK to break for a good reason. |
|
The CI failures appear to be unrelated. |
|
The CI job failure appears to be unrelated, |
|
@rtpsw this will need a rebase. Some of the changes here were brought in with the backpressure change. Would you like me to do this or do you want to? |
|
|
I just rebased. I didn't try to take out the backpressure changes, but let me know if you want that. I left the |
westonpace
left a comment
There was a problem hiding this comment.
I think we can clean this up a little bit but otherwise it looks pretty solid.
|
@westonpace, I rebased again after fixing per your requests. |
westonpace
left a comment
There was a problem hiding this comment.
Thanks. I think we're good now.
|
Benchmark runs are scheduled for baseline = fc55807 and contender = 108a028. 108a028 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
See https://issues.apache.org/jira/browse/ARROW-18417