Repository navigation
Conversation
|
|
|
@westonpace Hi Weston, I wrote some new tests to validate that our in-order assertions are working (it returns an invalid status which is caught by ErrorIfNotOk) . They seem to detect the out-of-ordered test locally on my computer and it passes, but it seems to fail on the CI checks -- any idea why? |
There was a problem hiding this comment.
We raise the Invalid case here, and the status is processed by ErrorIfNotOk in InputReceived
|
I think I found the issue, doesn't seem like it passes always? EDIT: seems like some sort of race condition. We only run the check when are sure the |
|
Can you print thread id and see if input received is called by different
thread?( for the same input table). Also I think we can check when queue is
not empty too, we just need to remember the current timestamp in the input
state.
…On Tue, Aug 2, 2022 at 5:36 PM Ivan Chau ***@***.***> wrote:
I think I found the issue, doesn't seem like it passes always?
EDIT: seems like some sort of race condition. We only run the check when
are sure the queue has batches in it, however, it seems like in the cases
in which the tests fails, it is always empty. The execution context is
setup with nullptr as well. Any ideas here @icexelloss
<https://github.com/icexelloss> ?
—
Reply to this email directly, view it on GitHub
<#13771 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGBXLDCYVT3PCXTQLUBSOLVXGIEZANCNFSM55I6LW6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Resolved, was checking the last batch in the queue to find latest time, however these batches get consumed and the queue can become empty, instead introduce another instance variable to track latest time seen in the |
westonpace
left a comment
There was a problem hiding this comment.
Looks like a nice check to add. Thanks. CI has a way of running parallel tasks with pretty much the oddest scheduling you could possibly imagine so that is generally my first guess.
There was a problem hiding this comment.
I don't remember if this kind of access outside the mutex causes TSAN errors or not. Have you run TSAN locally?
There was a problem hiding this comment.
Hey Weston, I'm not sure how to run TSAN locally with ninja, is there some documentation on how to do this?
In any case, I don't actually think we use this method anywhere -- I'm going to remove this for now.
westonpace
left a comment
There was a problem hiding this comment.
Just a few minor style / nitpick requests.
36f5917 to
0c3707f
Compare
icexelloss
left a comment
There was a problem hiding this comment.
@iChauster Looks good I have a few minor comments please take a look
|
@westonpace - @iChauster has finished his internship last week so I will take this PR over. Let me know if you have more comments. |
|
@westonpace Are there more changes needed for this PR? |
|
@westonpace Anything else we need to do here for merging? |
|
Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍 |
Uh oh!
There was an error while loading. Please reload this page.