Skip to content

ARROW-14247: [C++] Fix Valgrind errors in parquet-arrow-test - #11356

Closed
lidavidm wants to merge 1 commit into
apache:masterfrom
lidavidm:arrow-14247
Closed

lidavidm wants to merge 1 commit into
apache:masterfrom
lidavidm:arrow-14247

Conversation

@lidavidm

@lidavidm lidavidm commented Oct 7, 2021

Copy link
Copy Markdown
Member

Googletest prints all test parameter objects up front. When there's no custom printer defined, it just prints the bytes of the struct. This happened to go into uninitialized memory in (apparently) std::string, tripping Valgrind.

See a discussion by Chromium developers on a similar issue: https://bugs.chromium.org/p/chromium/issues/detail?id=64887

@github-actions

github-actions Bot commented Oct 7, 2021

Copy link
Copy Markdown

@lidavidm

lidavidm commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-conda-cpp-valgrind

@github-actions

github-actions Bot commented Oct 7, 2021

Copy link
Copy Markdown

Revision: 7b59970

Submitted crossbow builds: ursacomputing/crossbow @ actions-904

Task Status
test-conda-cpp-valgrind Azure

@lidavidm

lidavidm commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

Valgrind still fails, but that should be fixed by #11350.

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you

@pitrou pitrou closed this in 3cacc85 Oct 7, 2021
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
Googletest prints all test parameter objects up front. When there's no custom printer defined, it just prints the bytes of the struct. This happened to go into uninitialized memory in (apparently) std::string, tripping Valgrind.

See a discussion by Chromium developers on a similar issue: https://bugs.chromium.org/p/chromium/issues/detail?id=64887

Closes apache#11356 from lidavidm/arrow-14247

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants