Skip to content

[C++] Some states in swiss join code are useless #45135

Closed

Description

@zanmato1984

Describe the enhancement requested

There exists a member in HashJoinNode identifying wether the hash table is built so we can proceed with probe in a very high level:

bool hash_table_ready_ = false;

So the following two states in SwissJoin:

std::atomic<bool> hash_table_ready_;

bool hash_table_ready;

are useless. We can also tell it from the fact that they are all written but never read (except for a DCHECK which is also unnecessary).

Component(s)

C++

Activity

  1. self-assigned this
    on Dec 31, 2024
  2. added a commit that references this issue on Dec 31, 2024
  3. added this to the 19.0.0 milestone on Dec 31, 2024
  4. zanmato1984 commented on Dec 31, 2024

    @zanmato1984
    ContributorAuthor

    Issue resolved by pull request 45136
    #45136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions