Skip to content

[C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::GetRecordBatchReader() #44808

Closed

Description

@kou

Describe the enhancement requested

The current version uses arrow::Status and std::unique_ptr<arrow::RecordBatchReader>*:

/// \brief Return a RecordBatchReader of all row groups and columns.
virtual ::arrow::Status GetRecordBatchReader(
std::unique_ptr<::arrow::RecordBatchReader>* out) = 0;
/// \brief Return a RecordBatchReader of row groups selected from row_group_indices.
///
/// Note that the ordering in row_group_indices matters. FileReaders must outlive
/// their RecordBatchReaders.
///
/// \returns error Status if row_group_indices contains an invalid index
virtual ::arrow::Status GetRecordBatchReader(
const std::vector<int>& row_group_indices,
std::unique_ptr<::arrow::RecordBatchReader>* out) = 0;
/// \brief Return a RecordBatchReader of row groups selected from
/// row_group_indices, whose columns are selected by column_indices.
///
/// Note that the ordering in row_group_indices and column_indices
/// matter. FileReaders must outlive their RecordBatchReaders.
///
/// \returns error Status if either row_group_indices or column_indices
/// contains an invalid index
virtual ::arrow::Status GetRecordBatchReader(
const std::vector<int>& row_group_indices, const std::vector<int>& column_indices,
std::unique_ptr<::arrow::RecordBatchReader>* out) = 0;

Component(s)

C++, Parquet

Activity

  1. added a commit that references this issue on Nov 22, 2024
  2. added a commit that references this issue on Nov 22, 2024
  3. added this to the 19.0.0 milestone on Nov 22, 2024
  4. kou commented on Nov 22, 2024

    @kou
    MemberAuthor

    Issue resolved by pull request 44809
    #44809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions