Skip to content

[C++][Acero] Use implicit_ordering for asof_join rather than require_sequenced_output #44629

Closed

Description

@EnricoMi

Describe the enhancement requested

Changes in #44083 (GH-41706) unnecessarily sequences batches retrieved from scanner where it only requires the batches to provide index according to implicit input order.

Setting implicit_ordering causes existing code to set batch index, which is then available to the asof_join node to sequence the batches int input order. This replaces some of #44083 changes.

Some code introduced by #44083 turns out to not be required and should be reverted.

Component(s)

C++

Activity

  1. changed the title [-]Use `implicit_ordering` for `asof_join` rather than `require_sequenced_output`[/-] [+][C++][Acero] Use `implicit_ordering` for `asof_join` rather than `require_sequenced_output`[/+] on Nov 3, 2024
  2. added a commit that references this issue on Feb 11, 2025
  3. added this to the 20.0.0 milestone on Feb 11, 2025
  4. zanmato1984 commented on Feb 11, 2025

    @zanmato1984
    Contributor

    Issue resolved by pull request 44616
    #44616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions