Skip to content

[C++] Dataset tests not running with Acero refactor #34871

Closed

Description

@westonpace

Describe the bug, including details regarding any error messages, version, and platform.

The change appears to be due to a change to ADD_ARROW_DATASET_TEST:

  add_arrow_test(${REL_TEST_NAME}
                 EXTRA_LINK_LIBS
                 ${ARROW_DATASET_TEST_LINK_LIBS}
                 PREFIX
                 ${PREFIX}
                 SOURCES # This is new
                 test_util_internal.cc # This is new
                 LABELS
                 ${LABELS}
                 ${ARG_UNPARSED_ARGUMENTS})

If SOURCES is specified then the implicit ${REL_TEST_NAME}.cc is not added. As a result, all it is compiling is test_util_internal.cc and no tests are discovered.

Component(s)

C++

Activity

  1. self-assigned this
    on Apr 3, 2023
  2. added a commit that references this issue on Apr 4, 2023
  3. added this to the 12.0.0 milestone on Apr 4, 2023
  4. added a commit that references this issue on May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions