Skip to content

[C++] Add an auto fallback solution when system Gtest is compiled with a C++ standard lower than 17. #34813

Closed

Description

@HaochengLIU

Describe the enhancement requested

in PR #34765, Arrow will error out when the detected GTest is compiled with a C++ standard lower than 17. This is a follow-up issue that should support auto fallback:

Proposed solution from @kou :

Add a FindGtestAlt.cmake file (GTestConfig.cmake is a good starting point) and use new target names to refer to suitable Arrow target. See details in this comment

Component(s)

C++

Activity

  1. HaochengLIU commented on Mar 31, 2023

    @HaochengLIU
    ContributorAuthor

    FYI I need to tackle #34565 first in April as it's related to my job. Once it's done I will revisit this enhancement.

  2. westonpace commented on Mar 31, 2023

    @westonpace
    Member

    Do you mean it would fallback to building from source?

  3. HaochengLIU commented on Mar 31, 2023

    @HaochengLIU
    ContributorAuthor

    yes, the goal is to support automatic fallback

  4. changed the title [-][C++] Add an auto fallback solution when system Gtest is cmpiled with a C++ standaard lower than 17.[/-] [+][C++] Add an auto fallback solution when system Gtest is compiled with a C++ standard lower than 17.[/+] on Apr 4, 2023
  5. added a commit that references this issue on Apr 6, 2023
  6. added this to the 12.0.0 milestone on Apr 6, 2023
  7. added a commit that references this issue on May 11, 2023
  8. added a commit that references this issue on May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions