Skip to content

[C++] Adding Fetch Node FromProto #32763

Closed

Description

@asfimport

Serializing FetchNode with Substrait. 

Reporter: Vibhatha Lakmal Abeykoon / @vibhatha

Note: This issue was originally created as ARROW-17503. Please see the migration documentation for further details.

Activity

  1. asfimport commented on Aug 23, 2022

    @asfimport
    Author

    Weston Pace / @westonpace:
    This seems like it will be tricky. The fetch node is a sink node. The consumer currently expects sink nodes to come from the caller. I'm not sure of a great way to work around this.

    Brainstorming on a currently meeting-fried brain I might think something like...

    • The FromProto for relation returns a current ordering and fetch info

    • Note, if FromProto is called and there is already an ordering / fetch info then it should be an error as Acero can't handle this

    • The ordering / fetch info is passed on to the declaration factory in addition to the other two inputs

    • The declaration factories (at least the consuming sink one) is extended so that, if an ordering / fetch info is present, then it uses the appropriate sink node.

      Maybe ordering / fetch info could be part of declaration info? CC @bkietz

  2. asfimport commented on Nov 22, 2022

    @asfimport
    Author

    Apache Arrow JIRA Bot:
    This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

  3. added this to the 13.0.0 milestone on May 22, 2023
  4. added a commit that references this issue on May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions